Changeset 20291 for juggler/branches/2.2/modules/gadgeteer/gadget/RemoteInputManager.cpp

Timestamp:

06/08/07 14:44:39 (1 year ago)

Author:

patrick

Message:

Fixed a potential mutex deadlock. To do this, I changed the pre-condition of
gadget::DeviceServer::debugDump() so that mClientsLock must be held prior to
calling this method. This is not exactly ideal, but the alternative is to
reduce the exception safety guarantee of gadget::DeviceServer::send(), and
that seems like a much worse scenario.

Files:

• juggler/branches/2.2/modules/gadgeteer/gadget/RemoteInputManager.cpp (modified) (1 diff)

juggler/branches/2.2/modules/gadgeteer/gadget/RemoteInputManager.cpp

@@ -449 +449 @@
-      for ( std::vector<DeviceServer*>::iterator j = mDeviceServers.begin(); j != mDeviceServers.end(); j++ )
-      {
+         (*j)->lockClients();
-         (*j)->debugDump(debug_level);
+         (*j)->unlockClients();
-      }
-   }